search

flipperdevices / flipperzero-firmware

Flipper Zero firmware source code
https://flipperzero.one
GNU General Public License v3.0
12.66k stars 2.7k forks source link

infrared: In C rewrite, can't exit with Back if launched via 'Run in app' #1338

Closed digitalcircuit closed 2 years ago

digitalcircuit commented 2 years ago

Describe the bug With the new Infrared C port, it's not possible to exit with the Back button after launching a saved Infrared remote via the Run in app archive browser option or from the Favorites (pinned) section.

To Reproduce

  1. Save (or copy) an infrared remote
  2. Go back to the Flipper desktop
  3. Press Down to enter archive view
  4. Press Right multiple times to navigate to Infrared
  5. Select the saved remote and press OK, then Run in app
  6. Press Back to try to exit the Infrared app's saved remote view

Expected behavior Pressing Back exits the Infrared app's saved remote view, as it did before the C rewrite.

In reality, you have to force-reboot the Flipper Zero (hold Left and Back) to exit the Infrared app after launching a saved remote via Run in app or from the Favorites screen.

Logs I am not sure what debug logs are relevant. Does this involve using the WiFi debugging probe? I can try setting that up if it would help.

Target Flipper Zero

Additional context This problem occurred after updating from Change "cad" to "card" to nfc: NTAG21x complete emulation. It's possible other changes impacted this, but as the SubGhz app correctly exits when launched via Run in app or from Favorites, I suspect it's the Infrared app C port.

gsurkov commented 2 years ago

Fix is in the dev branch.

digitalcircuit commented 2 years ago

I've confirmed that https://github.com/flipperdevices/flipperzero-firmware/commit/0b8331656069bbbd011f2dfa0b0c2a03b5d8a859 (https://github.com/flipperdevices/flipperzero-firmware/pull/1340) has fixed this issue, thank you!