search

flipperdevices / flipperzero-firmware

Flipper Zero firmware source code
https://flipperzero.one
GNU General Public License v3.0
11.73k stars 2.59k forks source link

Resources wont get updated if older update folder exists #1881

Closed ankris812 closed 1 year ago

ankris812 commented 1 year ago

Describe the bug.

If i upload an update, and there is already a folder on ext/update with that name,no files will be updated, it will skip them it happened when trying to update a local build of the firm, i was trying to change the flipper dict, deleted previous one, copied the new, without seeing that it had a typo on name, i fixed the typo, but when updating again error was still there.

Reproduction

Reproduction for my case:

delete mf_classic_dict.nfc ( i was setting my sd from zero, so this file didnt exist), rename on assets/resources/nfc/assets mf_classic_dict.nfc to mfc_classic_dict.nfc (i copied it without noticing the typo) compile, and update. fix the typo. compile again. load tgz with qflipper it will skip uploading and update again with old update error will still be there

Target

qflipper

Logs

37936 [UTL] Prepare Update @Korai SUCCESS
37936 [DBG] Update package has been already uploaded, skipping to update...
37937 [UTL] Start Update @Korai START

Anything else?

my build always take the name local, so folder inside update is always f7-update-local, so i dont know if this will happen on offical releases.

DrZlo13 commented 1 year ago

I do not think that this problem relates to the firmware, rather to the qFlipper.

ankris812 commented 1 year ago

I do not think that this problem relates to the firmware, rather to the qFlipper.

the firmware? is the firmware who uploads the updates files?

emory commented 1 year ago

i don't do updates with qflipper, i do them on-device. i keep a directory of my SD card layout as a repo and use rsync (rsync -azvP --delete local-copy/ /Volumes/SDCARD/) to refresh and i don't think i see the same behavior you're reporting. i haven't deleted an entire folder from my SDCARD yet if that's the test you're hoping to get confirmation on @ankris812 but i don't think i will ever use qflipper to do firmware installation personaly.

ankris812 commented 1 year ago

@emory the problem only happens when updating with qflipper. And i'll check what You do to update

skotopes commented 1 year ago

Upload script actually verifies checksums and skips upload if file was not changed. Are you sure that you have something to upload?

ankris812 commented 1 year ago

Yes. But i'll check It again anyways

El jue, 1 dic 2022 18:37, あく @.***> escribió:

Upload script actually verifies checksums and skips upload if file was not changed. Are you sure that you have something to upload?

— Reply to this email directly, view it on GitHub https://github.com/flipperdevices/flipperzero-firmware/issues/1881#issuecomment-1334120294, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6CI373ETZSYXGXNLAOEALWLDO45ANCNFSM6AAAAAARGMJSSU . You are receiving this because you were mentioned.Message ID: @.***>

hedger commented 1 year ago

This is qFlipper's issue, not the firmware's.

hedger commented 1 year ago

Also please use fbt flash_usb_full.