flipperdevices / flipperzero-firmware

Flipper Zero firmware source code
https://flipperzero.one
GNU General Public License v3.0
12.63k stars 2.69k forks source link

Subghz raw sub transmits an unwanted signal at the beginning (OOK 433MHz) #1923

Closed coded-with-claws closed 1 year ago

coded-with-claws commented 1 year ago

Describe the bug.

Hi!

I'm generating a raw sub file and when I play it with my flipper, it starts with some kind of preamble which I didn't write into the raw sub file:

I can't see any reason for this behavior, so I'm creating an issue (as I couldn't get info on discord when I asked about that).

Thanks :)

Reproduction

Download the attached .sub.txt file, rename to remove the ".txt" (which was added because of github supported file types). Open it in the Subghz application and hit Send, and capture in urh with a RTL SDR dongle.

pb_rawsub example.sub.txt

Target

No response

Logs

No response

Anything else?

No response

skotopes commented 1 year ago

@Skorpionm do you remember why we start transmission before furi_hal_subghz_start_async_tx is actually started? https://github.com/flipperdevices/flipperzero-firmware/blob/dev/applications/main/subghz/subghz_i.c#L106

Skorpionm commented 1 year ago

check current dev

skotopes commented 1 year ago

One more fix and unit tests arrived in latest dev. Please reopen if you still experiencing issue