NFC: SLIX no longer works

exussum12 commented 9 months ago

Describe the bug.

Both previously saved and trying to read a new card fail on the current firmware.

Flipper displays emulating iso15694-3 (unknown) when trying to emulate a previously working file

Reproduction

See above

Target

No response

Logs

No response

Anything else?

No response

gornekich commented 9 months ago

Hello @exussum12 ! Could you please provide your file dump? It will help to debug the issue.

exussum12 commented 9 months ago

Hey I can send it to someone on Discord or via email - whats best to send?

gornekich commented 9 months ago

Please ,send me on Discord. My nick is gornekich

gornekich commented 9 months ago

Still working on this issue. Planning to include support of all older file versions in next release 0.97

tdimov93 commented 9 months ago

hey @gornekich, I'm also noticing a couple of issues related to SLIX cards (SLIX2 in my case):

after reading a tag if I click on More -> Info, the Flipper reboots and shows a "NULL pointer dereference" message upon startup
trying to click on a saved SLIX2 file results in a "Cannot load key file", even if it was created by the flipper itself a second or two ago

I saw this running the official firmware v0.95.0

Please let me know if you'd like me to open a separate issue for this or if you think it might be related to the original issue (or handled as part of it). I'd be happy to assist with more information if necessary

gornekich commented 9 months ago

Hi @tdimov93 Thanks for information. I will work on SLIX support improvements soon and will ask you to reproduce this issues after I am done. No need in opening another issue, let's discuss it here.

tdimov93 commented 9 months ago

great, thanks!

Unfortunately I'll only have access to the problematic tag for another 6 days. I have the saved file that refuses to open so I'll be able to reproduce the 2nd issue after that without problems but the first issue would be impossible for me to reproduce after Tuesday. Let me know if I can help with grabbing some logs/traces that might help you identify or reproduce it on your end as I don't imagine you'll get around to working on it this week

exussum12 commented 9 months ago

I have a bunch of tags I can scan if needed

tdimov93 commented 9 months ago

Do you have any password-protected ones? I just received a pack of 20 fresh SLIX2 tags and I didn't manage to reproduce either of the 2 issues that I mentioned with them. It would seem the problems arise when the flipper fails to read the password-protected data section of the tag

exussum12 commented 9 months ago

Yeah I have passworded ones. The old firmware could unlock

On 6 December 2023 17:26:46 GMT, Theodor Dimov @.***> wrote:

Do you have any password-protected ones? I just received a pack of 20 fresh SLIX2 tags and I didn't manage to reproduce the either of the 2 issues I mentioned with them. It would seem the problems arise when the flipper fails to read the password-protected data section of the tag

-- Reply to this email directly or view it on GitHub: https://github.com/flipperdevices/flipperzero-firmware/issues/3212#issuecomment-1843340799 You are receiving this because you were mentioned.

Message ID: @.***>

tdimov93 commented 9 months ago

Which version are you referring to when you say old firmware? 0.94.1? Btw is there a way to grab the commands and responses in order to debug NFC with the flipper zero without an external tool? Haven't been able to find info on that

exussum12 commented 9 months ago

0.93 I think was the latest I could use.

exussum12 commented 8 months ago

Just tried 0.97.1 and this is sill broken

tdimov93 commented 7 months ago

Same. Regarding the issue I described, I compared the corrupt NFC file dump with a regular empty SLIX2 tag dump and saw that the problematic one has an empty Security Status: section. When I copied the section from the empty tag file over manually and saved it (it's a bunch of 0s), the flipper was able to parse it successfully. My guess is that given the original tag is likely password-protected, the flipper fails to read that section and ends up writing an empty data array instead of populating it with question marks for example and leaves the file corrupt. It would also explain the NULL pointer dereference crash when trying to go into the info section right after reading the tag.

gornekich commented 2 months ago

Hi @exussum12 . Could you please try lates dev again?

skotopes commented 2 months ago

Please check latest release, also use Capabilities: AcceptAllPasswords if you bypassing auth. Reopen if problem persist.

flipperdevices / flipperzero-firmware