flipperdevices / flipperzero-firmware

Flipper Zero firmware source code

https://flipperzero.one

GNU General Public License v3.0

11.69k stars 2.59k forks source link

Update bad_usb_app.c #3729

Closed ghost closed 1 week ago

ghost commented 1 week ago

What's new

Restructured functions for improved readability and maintainability.
Enhanced resource and error management for increased robustness.
Optimized memory usage and improved security with constant usage.

Verification

Ensure proper resource and file handling by testing with varied scenarios.
Validate error handling by deliberately causing errors during memory allocation and file operations.

Checklist (For Reviewer)

[x] PR includes a clear description of implemented changes.
[x] Description outlines steps to verify new features or bug fixes.
[x] Code has been compiled, deployed to the device, and functionality verified as expected.

skotopes commented 1 week ago

You clearly didn't pay attention nor to coding style nor to contribution section. 2 most important things:

our malloc never returns NULL
code formatting is automated, so use ./fbt format