flipperdevices / flipperzero-good-faps

Flipper Zero Official Apps maintained by Flipper Team and Friends
GNU General Public License v3.0
302 stars 55 forks source link

[NFC Magic] Add support for backdoor read commands for Gen 1A/1B tags #202

Closed mishamyte closed 5 days ago

mishamyte commented 1 year ago

Description of the feature you're suggesting.

Overview:

Right now NFC Magic app supports next functionality for magic tags:

It would be nice to add also support of read backdoor command. For that case flow of reading could be simplified. Instead of trying to authenticate with user dictionary + standard dictionary, tag could be read fully with a backdoor command.

Usage steps:

  1. Check if tag is magic Gen 1A/1B (existing functionality)
  2. Select read (for implementation)
  3. If tag was read without problems (potential problems while reading should be an extra investigation points), user could have a possibility to save the dump (and next steps should be done using standard Flipper's NFC experience)
  4. [Optional]: As a follow up for step 3, found keys could be added into user's dictionary (automatically or with user confirmation, validation for key existence in dictionary should be done)

Tech details for read commands:

Potential problems: Now detection of Gen 1 tags is done, using 40(7) command and concrete type (Gen1A/Gen1B) is not detected. For read it could be done via iteration through the read sequence for Gen1A, if didn't worked - for Gen1B. Which could ruin UX from the PoV of waiting time.

Implementation in existing products: It is implemented at least in next solutions:

Anything else?

No response

sealldeveloper commented 1 year ago

+1 on this, would really like to see this as a feature.

Using this without reading is frustrating :<

spetzreborn commented 6 months ago

I also want this feature. I have the possibility to use a card printer/writer. And this way would make it very easy for me to get the B keys as I just can write/print to an gen1a magic card.

Maybe this issue should be on the apps repo and not firmware as nfc magic is an standalone app there?

skotopes commented 6 months ago

Latest version NfcMagic support gen1/gen2 writing.

mishamyte commented 6 months ago

@skotopes I'm sorry, but the issue was about the backdoor read, which is still now implemented.

I agree that it would be better to have it in good faps repo.

Would it be good if I will reopen it there as a feature proposal?

skotopes commented 6 months ago

@mishamyte I've reopened and moved it to appropriate repository.