flipperdevices / qFlipper

qFlipper — desktop application for updating Flipper Zero firmware via PC
https://update.flipperzero.one
GNU General Public License v3.0
1.14k stars 152 forks source link

File browser: can not enter and exit folders when browsing #112

Closed agathakazar closed 1 year ago

agathakazar commented 2 years ago

Describe the bug When using the file browser I can use the arrow keys to switch between different files in the 4 directions. But I can not enter a folder when pressing 'Enter' or 'z' and I can not move up one level when pressing 'Backspace' or 'x'

To Reproduce Steps to reproduce the behavior:

  1. Go to File manager
  2. Try navigating the menu with the keyboard
  3. Try pressing the above mentioned buttons
  4. See that you can not navigate inside and outside of the folders

Expected behavior I expected to be able to navigate the same way I navigate Flipper menus when screen streaming.

Actual behavior I can't navigate because the buttons 'Enter', 'z', 'Backspace' and 'x' don't work.

Additional troubleshooting

  1. Does the issue persist if you try multiple times?
    • yes
  2. Does reconnecting/rebooting Flipper solve it?
    • no

The report must also include at least one of the following:

  1. A FULL LOG of this application run. (see below).
  2. A screenshot of the application window (if it is a graphical issue). 2022-08-29_16-33

Additional context The < and > buttons work wen navigating, but pressing them with the mouse is inconvenient.

gsurkov commented 2 years ago

Frankly speaking, the fact that it's sometimes possible to use keyboard navigation in the file manager is not an intended behaviour, but rather just a property of the GridView Qml component used in its implementation.

Although keyboard navigation sounds like a logical thing, from my experience it's quite tricky to make that work in Qml. The components tend to lose focus for whatever reason and the behaviour varies from platform to platform. (It took some hacks to even get the D-Pad from screen streaming working.)

This said, I can't promise that it will be implemented, but it is worth trying sometime in the future.

gncnpk commented 1 year ago

This should be working now! Let us know if you experience any issues :)