search

flipperdevices / qFlipper

qFlipper — desktop application for updating Flipper Zero firmware via PC
https://update.flipperzero.one
GNU General Public License v3.0
1.14k stars 152 forks source link

Fix rules for non logind systems #67

Closed Vaelatern closed 2 years ago

Vaelatern commented 2 years ago

This might help fix this person's problem https://www.reddit.com/user/Junkyard_DrCrash/comments/uad4td/flippers_wont_connect_to_qflipper_except_in_dfu/

It has definitely fixed my problems.

It also allows distro maintainers to easily copy the udev script into position.

zhovner commented 2 years ago

What is the distro-way to supply this udev scripts? Tired of pointing people to run scripts manually.

Vaelatern commented 2 years ago

Install to ${DESTDIR}/${PREFIX}/lib/udev/rules.d/ inside the package (assuming a packaging effort)

Vaelatern commented 2 years ago

For random reference, this is the package for Void Linux (will be merged after it's usable on my systems as installed, which waits only on this PR) https://github.com/Vaelatern/void-packages/commit/9434f122b81617920470a95fd9cf0a2a8c312c21

By the way, I am greatly enjoying this tool and my flipper zero. This tool, once I got it working, really helps make the flipper an extension of my computer.

Vaelatern commented 2 years ago

What should I do to make this PR get merged for the next release?

gsurkov commented 2 years ago

Sory for keeping you waiting.

The rules installation has been reworked for the upcoming 1.1.0 version. The script is now bundled within the AppImage and is invoked via a command line parameter. Additionally, make install now installs the rules file to an appropriate location (see README). The changes are already in the main (dev) branch and are undergoing testing along with other features before the release.

Vaelatern commented 2 years ago

A better set of fixes, getting rid of the hacky script entirely :)

gsurkov commented 2 years ago

Assuming this has helped, closing the PR. Please feel free to suggest further improvements if the current implementation is not enough.