search

flipperdevices / qFlipper

qFlipper — desktop application for updating Flipper Zero firmware via PC
https://update.flipperzero.one
GNU General Public License v3.0
1.14k stars 152 forks source link

Comments on osx build and markdown linting (M1, arm64, building) #96

Closed daconstenla closed 11 months ago

daconstenla commented 2 years ago

This change fixes most of the warnings shown by markdownlint from the README.md and contrib/README.md.

markdownlint README.md 2>&1 |wc -l
      66

after the adjustments there are 10 warnings all related to line length:

markdownlint README.md 2>&1 |wc -l             
      10

It also does add one missing dependency when building on OSX (create-dmg) and a comment about qt@6 not being compatible yet, I've seen #69 which might fix this problem.

There is one more change which is "forced" architecture when using docker-compose to prevent trying to build with different than supported architecture linux/amd64, otherwise packages will fail to be found and installed.

daconstenla commented 1 year ago

Hi @zhovner thanks for the review!

I made those changes based on a markdownlint as mentioned in the description, there are 66 identified warnings, fixed those non related to line length.

I guess I could remove those markdown updates and just stick to m1 build.