search

flippidippi / sVim

Safari extension with shortcuts similar to Vim
Other
732 stars 52 forks source link

Problem with --normal-- inserted into fields #38

Open nikitavoloboev opened 8 years ago

nikitavoloboev commented 8 years ago

There is a very annoying bug that happens when posting on certain forums, this one for example. Where any post you make adds

'--- normal ---' to the end of any post you make. This is very annoying. Is it possible to either fix this bug? Perhaps you might not what the reason might be for it.

idx3d commented 8 years ago

+1, I've got the same issue on IP.Board engine forum

flippidippi commented 8 years ago

I think this is an issue with the way Safari tries to insert the plugin into frames etc., I honestly don't see a problem with the extension not working inside of elements like this on a webpage as I really only intend it on working on the main page. Maybe just disable the plugin from running anywhere other than the main page?

flippidippi commented 8 years ago

Link for reference on how to fix if we just make it only work on the top window.

if (window.top === window) {
   // The parent frame is the top-level frame, not an iframe.
   // All non-iframe code goes before the closing brace.
}
flippidippi commented 8 years ago

Also there is a way to blacklist sites, check this out

abrookins commented 5 years ago

This just snuck into an email that went out to my entire company. 😅 I will be focused on fixing it next week.

wella9cd7 commented 5 years ago

Any progress on this issue? I'm seeing it on forum I frequent...took me quite a while to realize it was sVim causing the "— NORMAL —" text :)