flipt-io / cup

Git Contribution Automation
https://cup.flipt.io
Apache License 2.0
76 stars 1 forks source link

fix(controllers/template): ensure list glob facets by gvk and ns #67

Closed GeorgeMac closed 1 year ago

GeorgeMac commented 1 year ago

This was causing any json file to be respected and returning by the template controller. This adds the same restrictions on the filename to ensure it contains the group, version and kind expected.

It also makes the templates configurable. Something I just never got around to wiring up before.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **cup** | ⬜️ Ignored ([Inspect](https://vercel.com/flipt/cup/AZ6Ki3cczqhz8WMaKbRANqH6Ggw9)) | [Visit Preview](https://cup-git-gm-fix-default-directory-template-flipt.vercel.app) | | Sep 14, 2023 10:26am |
GeorgeMac commented 1 year ago

Im going to be cheeky and sidestep approvals to get on with a demo video.