flipt-io / flipt-client-sdks

Flipt Client-Side Evaluation SDKs
https://www.flipt.io/docs/integration/client
MIT License
5 stars 6 forks source link

[FLI-969] Return error to caller after X times of failed connection #253

Open markphelps opened 2 months ago

markphelps commented 2 months ago

In #204 we fixed the panic that could occur if there is no connectivity to host

However now we simply silently fail and replace with an empty 'document' https://github.com/flipt-io/flipt-client-sdks/blame/969c177bf90068a28385a944f69a0ef956b62b33/flipt-engine-ffi/src/evaluator/mod.rs#L40

We should likely set a default threshold (and/or make it configurable) so that after X times of failing to get the snapshot data that we then return the error up to the calling clients so that its clear what is going on instead of silently failing

I suspect this is what is happening in this thread: https://discord.com/channels/960634591000014878/1232106900670382160/1232472006394642625

From SyncLinear.com | FLI-969