search

flipt-io / flipt-client-sdks

Flipt Client-Side Evaluation SDKs
https://www.flipt.io/docs/integration/client
MIT License
11 stars 5 forks source link

Wrong reference query param? #370

Closed AleksandrTermenzhy closed 3 weeks ago

AleksandrTermenzhy commented 3 weeks ago

Seems like there should be reference query param instead of ref here:

https://github.com/flipt-io/flipt-client-sdks/blob/6ab80d0eabb0e7e69b3f966840f9dafc5175b376/flipt-client-browser/src/index.ts#L44C1-L45C1

if (engine_opts.reference) {
- url = `${url}?ref=${engine_opts.reference}`; // not working, still pulls main
+ url = `${url}?reference=${engine_opts.reference}`; // working as expected
}
markphelps commented 3 weeks ago

yah you are right @AleksandrTermenzhy ! will push a fix now

AleksandrTermenzhy commented 3 weeks ago

Thanks @markphelps!

markphelps commented 3 weeks ago

Thanks for reporting @AleksandrTermenzhy ! the new version is going out now in CI