flipt-io / flipt

Enterprise-ready, GitOps enabled, CloudNative feature management solution
https://flipt.io
GNU General Public License v3.0
3.83k stars 218 forks source link

refactor(ui): remove nightwind as dependency #3599

Closed erka closed 2 weeks ago

erka commented 2 weeks ago

The main goal of this work is to reduce the size the output css file. Also Nightwind isn't active for few years and dropping such dependency would be nice. Tailwind was changed and doesn't require a lot of work to have custom colors.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.14%. Comparing base (d714c30) to head (510220f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3599 +/- ## ========================================== + Coverage 64.10% 64.14% +0.03% ========================================== Files 169 169 Lines 16956 16956 ========================================== + Hits 10870 10876 +6 + Misses 5404 5400 -4 + Partials 682 680 -2 ``` | [Flag](https://app.codecov.io/gh/flipt-io/flipt/pull/3599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flipt-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flipt-io/flipt/pull/3599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flipt-io) | `64.14% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flipt-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erka commented 2 weeks ago

looks great! would you mind running mage ui:fmt and committing? we have a prettier rule that organizes the tailwind class directives deterministically

it added even more changes...