flipzoom / ProcessWire-AIOM-All-In-One-Minify

AIOM+ (All In One Minify) is a ProcessWire module to easily improve the performance of your website. By a simple function call Stylesheets, LESS and Javascript files can be parsed, minimized and combined into one single file. This reduces the server requests, loading time and minimizes the traffic. In addition, the generated HTML source code can be minimized and all generated files can be loaded over a cookieless domain (domain sharding).
MIT License
33 stars 26 forks source link

Problems with line endings: Less files checkout from GitHub are processed differently from those I upload by FTP #25

Closed cpl-repo closed 9 years ago

cpl-repo commented 10 years ago

If I use on my server the same less files with AIOM+:

the final CSS are less-compiled differently.

When I add the less files to GitHub I get warning that my line-endings have been converted.

This might be due to different line endings on Windows and Linux. Can you reproduce that error?

cpl-repo commented 10 years ago

The error occured when I put a couple of linebreaks (e.g. 5) in a row. If I remove them, both versions (github + ftp) are compiled correctly.

marvinscharle commented 10 years ago

Hi cpl-repo,

in which environment are you working? Windows has different line-endings than Unix-based systems. GitHub - as far as I now - uses Unix line endings.

Furthermore, a warning when committing to GitHub seems to be a less-concerning problem for ProcessWire systems - as long as the files work properly on browsers.

Does this problem have any other negative effects beside the warning?

marvinscharle commented 9 years ago

This does not seem to be a problem anymore. Please reopen if the problem occurs in the future.