search

flipzoom / ProcessWire-AIOM-All-In-One-Minify

AIOM+ (All In One Minify) is a ProcessWire module to easily improve the performance of your website. By a simple function call Stylesheets, LESS and Javascript files can be parsed, minimized and combined into one single file. This reduces the server requests, loading time and minimizes the traffic. In addition, the generated HTML source code can be minimized and all generated files can be loaded over a cookieless domain (domain sharding).
MIT License
33 stars 26 forks source link

Permission 0777 not safe in some environments #44

Closed ryancramerdesign closed 8 years ago

ryancramerdesign commented 9 years ago

Thanks for this module. I was just implementing here for a client, and noticed it using hard-coded 0777 permission rather than ProcessWire's $config->chmodDir and $config->chmodFile. The server I'm working with is a typical shared server, where 0777 for dirs (0666 for files) is not safe because it means other users on the server and modify the files. The same is true in many hosting environments. I was wondering if you would consider using the PW config properties I mentioned above instead, or just use PW's wireChmod('/path/to/dir/or/file'); which automatically makes them writable consistent with the PW configured settings. Assuming those PW settings are configured properly, this ensures the safety of any writable directories or files.

adrianbj commented 9 years ago

Hey guys - what is happening with this - it looks like a critical, but easy thing to fix!

14pixels commented 8 years ago

Any Updates on this issue? Or is this module not maintained anymore?

flipzoom commented 8 years ago

We are sorry that it took a little longer. I currently have a lot to do. The problem has been solved.