search

flirtual / rovr

VR social network.
https://ROVRapp.com
GNU Affero General Public License v3.0
1 stars 0 forks source link

"You've got waves" weekly email #35

Closed anthony-ft closed 2 years ago

anthony-ft commented 3 years ago

Only if people have pending waves, and if they have not 1. passed accepted on the person 2. checked their guest list or 3. logged in since receiving the "someone waved at you email".

The 3 are in descending order of activity required - do you have a preference which to use? I'd say it's checking their guest list that counts as having checked their waves.

kfarwell commented 3 years ago

We shipped 1.2 a month ago ;)

kfarwell commented 3 years ago

I think pending waves should be "dismissed" (for email notification purposes) when either (1) the user waves back (2) the user passes on the waver or (3) the user visits their notifications page.

Any of these three actions should dismiss the wave. I think this minimizes false positives and negatives. If you visit your notifications page you almost certainly looked at your notifications, but visiting your guest list doesn't mean you saw all five profiles on it.

anthony-ft commented 3 years ago

Got it these sound good - so visiting your notifs clears your pending waves email, but doesn't take the wave itself away from your notifs rights? I.e. a wave is still sitting there afterwards if you look at your notifs, even if you don't accept or pass.

On Sat., Oct. 9, 2021, 12:28 a.m. Kyle Farwell, @.***> wrote:

I think pending waves should be "dismissed" (for email notification purposes) when either (1) the user waves back (2) the user passes on the waver or (3) the user visits their notifications page.

Any of these three actions should dismiss the wave. I think this minimizes false positives and negatives. If you visit your notifications page you almost certainly looked at your notifications, but visiting your guest list doesn't mean you saw all five profiles on it.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/rovrlabs/rovr/issues/35#issuecomment-939223962, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3IZKRPNF2R6NNDZ6JUN4DUF7AFLANCNFSM5FNIIATA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Anthony Tan Co-founder rovrapp.com

kfarwell commented 3 years ago

Right.

kfarwell commented 3 years ago

@anthony-ft Would you like to write this digest email?

Apart from the email template, this feature is implemented.

kfarwell commented 2 years ago

Notification setting isn't working... reopening