search

flix-tech / yabeda

A tool that sends deployment notifications from Gitlab CI to Slack
MIT License
6 stars 0 forks source link

Allow to run local commands instead of REST interface only #16

Open virtuman opened 4 years ago

virtuman commented 4 years ago

It doesn't really seem like a running service is necessary when running as a gitlab-ci job. For example:

.gitlab-ci.yml

...
...
..
slack-notify:
  image: myrepo/yabeda
  script:
  - python3 somelocalscript.py

in this way - all gitlab CI ENVIRONMENT VARIABLES are defined in the scope of the JOB's container, and don't need to be passed manually. Also, don't need an overhead of maintaining a running yabeda service.

a container would start up, execute command, and shutdown. I guess it could similarly be achieved by running command like curl localhost ..... inside the container (just dont see a good reason to have to structure script command with pre-defined variable names) as in:

  script:
  - http --check-status --ignore-stdin -f POST "https://localhost/report/$CI_PROJECT_PATH" pipeline_id=${CI_PIPELINE_ID} token=${YABEDA_TOKEN} channel=random
urmaul commented 4 years ago

The main feature of yabeda is the fact that it doesn't just post the message and forget. Instead of this yabeda keeps running in background, refreshes pipeline state and updates slack message with deployment status. Yabeda stops working only when the whole pipeline finishes and it will never happen if yabeda is the part of pipeline.