search

flix / flix

The Flix Programming Language
https://flix.dev/
Other
2.11k stars 149 forks source link

Fix "Cannot invoke "ParallelismManager.canFork(int)" because "this.parallelismManager" is null" #5676

Open magnus-madsen opened 1 year ago

magnus-madsen commented 1 year ago

In upstream pjbdd

magnus-madsen commented 1 year ago

https://gitlab.com/sosy-lab/software/paralleljbdd/-/issues/25

magnus-madsen commented 1 year ago

@jaschdoc or @sockmaster27 Would either of you be interested?

jaschdoc commented 1 year ago

So do you want a workaround in Flix or a PR in the PJBDD upstream that fixes it? In Flix, we could check for the number of available processors before using it and then possible switch to some other BDD package or the table based solution we had before BDDs were implemented. Thoughts?

magnus-madsen commented 1 year ago

PR to PJBDD that fixes it.

jaschdoc commented 1 year ago

How urgent is it? It seems like @sockmaster27 has quite a lot of stuff to work on, so maybe I should do it? Unless of course he thinks this would be fun?

magnus-madsen commented 1 year ago

It is not urgent.

jaschdoc commented 1 year ago

Okay, then it may be a while before I take a look at it. :)

sockmaster27 commented 9 months ago

After like 4 hours I still can't get that to build.

magnus-madsen commented 9 months ago

After like 4 hours I still can't get that to build.

Sucks :(

magnus-madsen commented 9 months ago

Maybe we need to add a workaround where we dont use PJBDD if there is one core.

magnus-madsen commented 9 months ago

Ill let Jakob take a stab at this (but it is not a priority for now).

magnus-madsen commented 3 months ago

I hope we can drop usage of PJBDD in the near future.