search

flix / programming-flix

A tutorial for programming in Flix
Apache License 2.0
6 stars 13 forks source link

feat: add page for type classes #33

Closed mlutze closed 2 years ago

mlutze commented 3 years ago

Fixes https://github.com/flix/programming-flix/issues/32

mlutze commented 2 years ago

@magnus-madsen Still WIP, but any comments so far?

magnus-madsen commented 2 years ago

If you do a pass, I will merge this in. (Drop the TODOs) :)

magnus-madsen commented 2 years ago

Let's go then I merge and we can switch to mdBook :)

magnus-madsen commented 2 years ago

You removed the package lock. Please restore it :)

mlutze commented 2 years ago

Package lock is still there, just much smaller. It did that when I ran npm install. Everything runs properly with the smaller lock file.

But I know very little about npm etc., so maybe I am missing something?

magnus-madsen commented 2 years ago

Package lock is still there, just much smaller. It did that when I ran npm install. Everything runs properly with the smaller lock file.

But I know very little about npm etc., so maybe I am missing something?

TLDR: Never change the lockfile. Please restore it :)

Changing the lockfile is akin to changing the dependencies-- that's something I manage.

mlutze commented 2 years ago

I reverted the lockfile change, but that makes CI fail.