Closed ninaandrup closed 2 years ago
Good work so far 👍
I'm a bit unsure of this example:
def map(f: a -> b & e, l: List[a]): List[b] & e = ...
The code in the flix library is & ef
instead of & e
We have decided to use ef
(instead of e
) by convention.
Here Eq is not defines for the enum. Does it matter, since it is illustrating Using Enums from a Namespace
?
Here Eq is not defines for the enum. Does it matter, since it is illustrating
Using Enums from a Namespace
?
You can sneak in a with Eq
on the relevant enum.
I think maybe this paragraph needs to be rewritten. I could not find any functions in the library using an argument f: a ~> Unit
. Everything is changed to f: a -> Unit & ef
, right?
I think maybe this paragraph needs to be rewritten. I could not find any functions in the library using an argument
f: a ~> Unit
. Everything is changed tof: a -> Unit & ef
, right?
Trying it out in VS code
, I can see, that f: a ~> Unit
won't compile.
On the same page, there is already this paragraph about effect polymorphism
. Maybe the other paragraph should just inform the user, that specifying an argument function as impure
is not possible?
I think maybe this paragraph needs to be rewritten. I could not find any functions in the library using an argument
f: a ~> Unit
. Everything is changed tof: a -> Unit & ef
, right?Trying it out in
VS code
, I can see, thatf: a ~> Unit
won't compile. On the same page, there is already this paragraph abouteffect polymorphism
. Maybe the other paragraph should just inform the user, that specifying an argument function asimpure
is not possible?
Mentioned again here in the table.
Should I open some new issues for the paragraphs needing to be rewritten and such?
Should I open some new issues for the paragraphs needing to be rewritten and such?
Yes. Lets keep this PR for simple things and then make a new issue for the things where new sentences are needed.
Can you open a new ticket for the fixpoint issue? Then I will ask Jonathan to take a look.
Can you open a new ticket for the fixpoint issue? Then I will ask Jonathan to take a look.
Sure :) see #67
Related to #60
In this PR
There are still open issues for some of the pages. But everything not in those issues should be fixed in this PR.