search

flix / vscode-flix

Apache License 2.0
20 stars 19 forks source link

chore: introduce flix.allJobsFinished #395

Closed sockmaster27 closed 2 months ago

sockmaster27 commented 3 months ago

Builds on #394

sockmaster27 commented 3 months ago

While this still requires waiting on the file system watcher, my hope is that it's an overall improvement since it reduces the uncertainty of how long it takes to compile.

magnus-madsen commented 3 months ago

Needs rebase then I will take a look :)

sockmaster27 commented 3 months ago

🫤

magnus-madsen commented 3 months ago

I think the adding/removing stuff is complex. Perhaps we should add tests for all providers before we consider how to deal with this?

magnus-madsen commented 3 months ago

Its possible the whole queue system has to be changed. But I would prefer to take smaller steps.

sockmaster27 commented 3 months ago

I can sort of recreate this using WSL but even more extreme where the diagnostics never even show up. Maybe there's just a bug? Could it be that the ordering of the connection is implemented in a non-ordered way on Linux such that the clearing signal arrives after the updated diagnostics? Maybe it has to do with some of those error messages it's spewing out?

magnus-madsen commented 3 months ago

I can sort of recreate this using WSL but even more extreme where the diagnostics never even show up. Maybe there's just a bug? Could it be that the ordering of the connection is implemented in a non-ordered way on Linux such that the clearing signal arrives after the updated diagnostics? Maybe it has to do with some of those error messages it's spewing out?

Unfortunately I have no idea. Perhaps you can explore what other extensions do?

sockmaster27 commented 3 months ago

@magnus-madsen Possible workaround: Run tests on Windows or macOS instead. We're not paying anything for the Actions on this repo are we? If we aren't, then I don't believe this would cost any thing extra.

magnus-madsen commented 3 months ago

@magnus-madsen Possible workaround: Run tests on Windows or macOS instead. We're not paying anything for the Actions on this repo are we? If we aren't, then I don't believe this would cost any thing extra.

We are not paying anything no. But I don't know if we have access to Windows or Mac. Do you get that for free?

sockmaster27 commented 2 months ago

@magnus-madsen Possible workaround: Run tests on Windows or macOS instead. We're not paying anything for the Actions on this repo are we? If we aren't, then I don't believe this would cost any thing extra.

We are not paying anything no. But I don't know if we have access to Windows or Mac. Do you get that for free?

That's how I understand it: https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions They have minute multipliers but if we have unlimited minutes I don't see how it would change anything.

sockmaster27 commented 2 months ago

🫤

sockmaster27 commented 2 months ago

@magnus-madsen Could you try to retrigger the tests a couple of times to check if they're reliable?

magnus-madsen commented 2 months ago

I have changed my mind and I now agree that adding some infrastructure to inspect the queue is the way to go.