search

flix / vscode-flix

Apache License 2.0
20 stars 19 forks source link

test: give each test suite an indepedent workspace #403

Closed sockmaster27 closed 1 month ago

sockmaster27 commented 1 month ago

Gives each test-suite its own workspace in the test/testWorkspaces/ directory. The contents of each workspace is then copied to the test/activeWorkspace/ directory at the appropriate time.

sockmaster27 commented 1 month ago

I believe so, but the whole thing tends to be fragile in general. I had to try out some different approaches to get the tests to pass, as seemingly valid combinations of commands and actions caused them to either hang or not reset correctly. It should be pretty solid now, but I can't guarantee that new problems won't appear in the future.

sockmaster27 commented 1 month ago

Even better could we track the files we are supposed to delete?

I tried it, but it becomes annoying when a test run is canceled mid-way (if it's hanging for example). Then that information is lost, and you'll need to delete the files manually, or the test starts acting weird.

magnus-madsen commented 1 month ago

Even better could we track the files we are supposed to delete?

I tried it, but it becomes annoying when a test run is canceled mid-way (if it's hanging for example). Then that information is lost, and you'll need to delete the files manually, or the test starts acting weird.

OK, but then let us at least limit ourselves to deleting files with the expected extension e.g. .flix and whatelse.

sockmaster27 commented 1 month ago

The test failure is because of the Circle(Int32) vs case Circle(Int32) bug. It should otherwise be safe to merge.

magnus-madsen commented 1 month ago

The test failure is because of the Circle(Int32) vs case Circle(Int32) bug. It should otherwise be safe to merge.

Can we mark that specific test as ignore?

magnus-madsen commented 1 month ago

Thanks!