search

flix / vscode-flix

Apache License 2.0
20 stars 23 forks source link

test: increase testing of providers #409

Closed sockmaster27 closed 2 months ago

sockmaster27 commented 4 months ago

Fixes #393

magnus-madsen commented 3 months ago

Looks like this is shaping up nicely. I am not sure why all the Flix source files start with an empty line. That seems like a potential for future confusion.

Once the tests work, I guess we are more prepared to refactor the plugin?

sockmaster27 commented 3 months ago

Looks like this is shaping up nicely. I am not sure why all the Flix source files start with an empty line.

It was just practical, to make sure doing anything on position (0,0) should be a no-op, as a sanity check.

magnus-madsen commented 3 months ago

Looks like this is shaping up nicely. I am not sure why all the Flix source files start with an empty line.

It was just practical, to make sure doing anything on position (0,0) should be a no-op, as a sanity check.

I think it could cause issues when someone has to copy some updated source code. We could add a comment saying blank or something.

magnus-madsen commented 3 months ago

Let me know when this is ready for review / merge.

sockmaster27 commented 3 months ago

SymbolProvider appears to contain some bug (Illegal argument: line must be non-negative: Error: Illegal argument: line must be non-negative).

magnus-madsen commented 3 months ago

Can you open a bug report with the input on the Flix repo? And then we can skip that provider.

sockmaster27 commented 3 months ago

@magnus-madsen Test got rate limited, could you retrigger it?

magnus-madsen commented 2 months ago

Merged. Thanks!