flixclusiveorg / Flixclusive

A TV show and movie player application.
MIT License
392 stars 36 forks source link

Support for Non PIP devices #118

Closed freakynuell closed 3 months ago

freakynuell commented 3 months ago

Steps to reproduce

Tries to play any movie Movie plays for 0.2s crashes out with log details

Expected behavior

Video player should work without PiP support

Actual behavior

Crashes after 0.2sec of playback

Crash logs (or stack trace)

java. lang. IllegalStateException: setPictureInPictureParams: Device doesn't support picture-in-picture mode at android.os.Parcel.createException(Parcel.java: 1958) at android.os.Parcel. readException(Parcel.java: 1918) at android.os.Parcel. readException(Parcel.java: 1868) at android.app.IActivityManager$Stub$Proxy.SetPictureInPictureParams(IActivityManager. java: 8997) at android.app.Activity.setPictureInPictureParams(Activity.java:2197) at com. flixclusive.mobile.MobileActivity$$ExternalSyntheticApiModelOutline0.m(Unknown Source:0) at com.flixclusive.core.ui.player.util.PlayerPiPHelperKt.updatePiPParams(PlayerPiPHelper.kt:96) at com.flixclusive.core.ui.player.util.PlayerUiUtil$AudioFocusManager$2$1$1.invokeSuspend(PlayerUiUtil.kt: it kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) t kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt: 108) t androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.

App version

2.0.0

Android version

7

Device

Android Tv

Other details

![Uploading IMG_3529.jpeg…]()

Acknowledgements

rhenwinch commented 3 months ago

wait what... I thought I handled this properly.

alr, expect fix on next update. sorry for inconvenience :')

freakynuell commented 3 months ago

wait what... I thought I handled this properly.

alr, expect fix on next update. sorry for inconvenience :')

thanks for acknowledging this early, I do have high hopes for this app and hope it is fixed soonest

rhenwinch commented 3 months ago

Seems like youre tryna use the mobile launcher on TV mode. I guess I'll just add an option to turn off PiP

This should also allow people to use the app on TV using the mobile launcher, temporarily.