Data variables can have their own dimensional order, but the observations can only have one dimensional order.

flo-schu / pymob

Python model building platform

MIT License

0 stars 0 forks source link

Data variables can have their own dimensional order, but the observations can only have one dimensional order. #76

Open flo-schu opened 2 weeks ago

flo-schu commented 2 weeks ago

This is potentially confusing, because all data-variables in the SimulationBase.observations follow the same order, but in the individual dimensions they can very.

This won't be a problem in most cases, because I assume users will not explore scenarios in which data variables have differently ordered dimensions in the regular application, but it could lead to errors, and at least ambiguities.

flo-schu commented 2 weeks ago

[ ] at least raise a warning if data variables have different dimensional orders.
[ ] It is convenient to allow individual dimensional order for variables in parse input. But the overall dimensional order could be re-established after parsing.
[ ] This could go together with a config.data_structure.dimensional_order property, that arranges the variables