floatdrop / gulp-plumber

Fixing Node pipes
MIT License
806 stars 32 forks source link

0.6.6 Broken #24

Closed jmcbee closed 9 years ago

jmcbee commented 9 years ago

I think it doesn't let the gulp task finish anymore.

[17:51:13] Plumber found unhandled error:
 Error in plugin 'gulp-less'
Message:
    Unrecognised input in file g:\www\luto\app\styles\main.less line no. 7
Details:
    type: Parse
    filename: g:\www\luto\app\styles\main.less
    index: 67
    line: 7
    callLine: NaN
    callExtract: undefined
    column: 0
    extract: ,,
    lineNumber: 7
    fileName: g:\www\luto\app\styles\main.less

Compared to:

[18:03:23] Plumber found unhandled error: Error in plugin 'gulp-less'
Message:
    missing closing `}` in file g:\www\luto\app\styles\main.less line no. 5
Details:
    type: Parse
    filename: g:\www\luto\app\styles\main.less
    index: 66
    line: 5
    callLine: NaN
    callExtract: undefined
    column: 5
    extract: ,body {,  background: red;
    lineNumber: 5
    fileName: g:\www\luto\app\styles\main.less
[18:03:23] Finished 'dev-styles' after 27 ms

0.6.5 works.

floatdrop commented 9 years ago

0.6.6 fixes only error output, there was no breaking changes in error handling. Could you provide instructions on how to reproduce this?

jmcbee commented 9 years ago

I checked the commits earlier, couldn't find anything w/c could have broken anything. I think it must have been some dependency issue. I reinstalled and it worked fine. Weird.

karlhorky commented 9 years ago

Hm, I'm having issues with the latest versions of gulp-plumber and gulp-less too. Maybe related to this? plus3network/gulp-less#152

This reduced test case fails for me: https://gist.github.com/austinpray/bbc4886ef950d6abd1e9

jmcbee commented 9 years ago

let it go :snowman: