search

floatdrop / gulp-watch

Watch, that actually is an endless stream
MIT License
643 stars 99 forks source link

Update to newest vinyl for gulp 4 support #296

Closed phated closed 6 years ago

phated commented 6 years ago

@UltCombo can you get this merged and published right away? A lot of people are having trouble with the new alpha of gulp 4 due to outdated vinyl deps.

erikkemperman commented 6 years ago

Need to check why tests are failing, but +1 for the vinyl upgrade!

namoscato commented 6 years ago

It looks like the AppVeyor failure is caused by the latest version of npm@5.6.0 running on an older version of Node v0.12. While I did not test this on Windows, I was able to replicate the issue on my MacBook, and the issue was resolved by downgrading to npm@2.15.11, which is bundled with Node v0.12.

I am unfamiliar with AppVeyor, but we might look at removing:

https://github.com/floatdrop/gulp-watch/blob/608c7aa47ebe3d19b55fee703b30d5245a7229ee/appveyor.yml#L12

The Travis CI ENOSPC failures seem to point to resource constraints and relate to gulpjs/gulp#217 / stackoverflow.com/q/16748737.

phated commented 6 years ago

@namoscato We've been using npm@^3 for gulp projects.

phated commented 6 years ago

@floatdrop @UltCombo any word on when this will get updated?

floatdrop commented 6 years ago

@phated we need to check why ENOSPC happens – tests are not watching so many files. (just started build again, and it's passed – may be travis wierd bug)

floatdrop commented 6 years ago

Gulp.js is still on 3.9.1 version, so we can publish updated vinyl only on latest tag (as gulp does).

phated commented 6 years ago

Vinyl 2.1 is released as latest and is backwards compatible. This needs to get updated because the gulp 4 release is only a few days away.

floatdrop commented 6 years ago

Vinyl 2.1 is released as latest and is backwards compatible. This needs to get updated because the gulp 4 release is only a few days away.

@phated I understand that, but still this should be released as major bump or with custom tags. I'm preferring bumping major versions for this. @UltCombo any thoughts on this?

phated commented 6 years ago

I think bumping major is good. But you probably want to wait for the upcoming chokidar v2 then. I'll be working on that tomorrow.

phated commented 6 years ago

@floatdrop chokidar bumped to 2.0 the other day. Want to get that + vinyl 2.1 merged into master and major bump?

phated commented 6 years ago

Ping again @floatdrop