search

floating-ui / react-popper

🍿⚛Official React library to use Popper, the positioning library
https://popper.js.org/react-popper/
MIT License
2.51k stars 225 forks source link

Add engines to package.json #377

Closed MichaelDeBoey closed 4 years ago

FezVrasta commented 4 years ago

I don't think that's something useful for a frontend project, according to the npm documentation it's meant to be used to specify the version of node that your stuff works on, this project is not dependant by any node version.

MichaelDeBoey commented 4 years ago

@FezVrasta It's not required, but it helps to have the minimum supported/tested Node version in package.json

It's mostly the minimum node version you're testing against.

https://github.com/jaydenseric/apollo-upload-client/blob/219002c88a34aade4c0fd1f89865f560ac730804/package.json#L32-L34

https://github.com/facebook/react/blob/147179ae82039f38fa1a9a72402f578af8fb3ea3/packages/react/package.json#L28-L30

FezVrasta commented 4 years ago

I'm not testing against any node version, the package is a client-side code.