floating-ui / react-popper

🍿⚛Official React library to use Popper, the positioning library

https://popper.js.org/react-popper/

MIT License

2.5k stars 226 forks source link

React 18 support #440

Closed atomiks closed 2 years ago

atomiks commented 2 years ago

Closes https://github.com/floating-ui/react-popper/issues/349

layershifter commented 2 years ago

@atomiks friendly ping, any estimates when this could be released?

ErrorEater commented 2 years ago

When will React 18 be supported? Upgraded and stuck.

FezVrasta commented 2 years ago

I need to find some time to make this PR pass the tests, if anyone wants to contribute please do so 🙇 otherwise I'll try to do it as soon I have some time available

chentsulin commented 2 years ago

Hi @FezVrasta, I created #441 and made some changes to fix the tests there.

chentsulin commented 2 years ago

@FezVrasta How about releasing a new minor version based on this PR?

FezVrasta commented 2 years ago

Waiting to understand if we also need https://github.com/floating-ui/react-popper/pull/439

ErrorEater commented 2 years ago

Waiting to understand if we also need #439

Ready to release? We're stuck.

atomiks commented 2 years ago

439 is not relevant for now, just release @FezVrasta

FezVrasta commented 2 years ago

2.3.0 is now live with these changes

varand-pez commented 1 year ago

I'm using Semantic UI React and found a thread about this issue in that repo which led me here. Just wanted to say this is still happening. I'm using semantic-ui 2.13 which uses react-poper 2.3.0 and react 18.2.0