search

floating / frame

System-wide Web3 for macOS, Windows and Linux
https://frame.sh
GNU General Public License v3.0
1.09k stars 150 forks source link

Frame unable to connect to anything after adding custom chain through wallet_addEthereumChain #1501

Open michecode opened 1 year ago

michecode commented 1 year ago

Hi I'm working on a dApp network selector and I noticed that frame starts to break once I added the Mumbai testnet through the wallet_addEthereumChain method. First the mainnet option is gone in the extension. I can remove the other networks and readd them but mainnet never comes back.

image

This may be unrelated but once I added Mumbai, Frame seems to break across all websites. I can't connect my wallet to anything (Tested aave, zksync bridge, and uniswap). I use web3modal for this dApp and I get spammed User Rejected errors even though frame does not open and I have set the permission to connect previously.

Using Reset all settings & data and then re-adding all of my wallets worked but I really don't want to do that every time.

goosewobbler commented 1 year ago

@michecode This might be related to a different bug in which a broken custom Mainnet connection will break the send dapp and cause issues in the extension. Does this happen for other chains added through wallet_addEthereumChain or is it specific to Mumbai?

michecode commented 1 year ago

I just reset it again to try to see if I could reproduce but I wasn't able to. It probably isn't specific to mumbai, I also added OP goerli and ARB goerli through the same method as adding mumbai. It hasnt broken yet but this time I haven't loaded my other wallets into frame or customized the settings at all. It did take a couple hours or so before it broke last time so I dont know.

But this time the Mainnet option in the extension is still there so I assume that when it disappears is when the connections start breaking for all chains.

michecode commented 1 year ago

Hey small update. Mainnet disappeared again yesterday but Frame was still able to connect but now today it's back to same issue. It could be related to time or letting my mac go to sleep? Let me know if there's any actions I can take to help debug!

goosewobbler commented 1 year ago

@michecode We've got some fixes in the pipeline for this, we're working hard to get them in the next release. We'll loop back here when the release is out, check that it solves your issue and debug further if not. In the meantime you should try to keep your mainnet connection healthy, maybe use some different RPC - current behaviour is that it will disappear from the extension when the connection is gone. We are changing this so that the extension will report connection status.

gosuto-inzasheru commented 1 year ago

@michecode This might be related to a different bug in which a broken custom Mainnet connection will break the send dapp and cause issues in the extension. Does this happen for other chains added through wallet_addEthereumChain or is it specific to Mumbai?

can you link this issue? i myself have a problem where sometimes the mainnet chain option disappears from the companion extension, and only altchains remain visible/connectable/selectable.

gosuto-inzasheru commented 1 year ago

hmm actually looks like it was just because it couldnt connect to the rpc. kinda weird that the option the disappears from the companion, a red dot showing the network name but its inability to connect would make for better ux imo.

either way sorry to hijack the discussion...

goosewobbler commented 1 year ago

@michecode This might be related to a different bug in which a broken custom Mainnet connection will break the send dapp and cause issues in the extension. Does this happen for other chains added through wallet_addEthereumChain or is it specific to Mumbai?

can you link this issue? i myself have a problem where sometimes the mainnet chain option disappears from the companion extension, and only altchains remain visible/connectable/selectable.

There is no issue to link that you can see, it's on our internal work tracking app. These PRs will address it though: https://github.com/frame-labs/frame-extension/pull/38 https://github.com/floating/frame/pull/1502 https://github.com/floating/frame/pull/1503