floating / frame

System-wide Web3 for macOS, Windows and Linux
https://frame.sh
GNU General Public License v3.0
1.09k stars 150 forks source link

Building from source on apple silicon #1553

Closed pandadefi closed 1 year ago

pandadefi commented 1 year ago

I am trying to build the project on an apple silicon machine. I am getting an error with the node usb lib when building it gets the following error.

npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: no member named 'GetContents' in 'v8::ArrayBuffer'
npm ERR!       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
npm ERR!                                   ~~~~~~~~^
npm ERR! ../src/node_usb.cc:151:7: warning: 'MakeCallback' is deprecated [-Wdeprecated-declarations]
npm ERR!         Nan::MakeCallback(Nan::New(hotplugThis), "emit", 2, argv);
npm ERR!              ^
npm ERR! ../../nan/nan.h:1001:3: note: 'MakeCallback' has been explicitly marked deprecated here
npm ERR!   NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
npm ERR!   ^
npm ERR! ../../nan/nan.h:103:40: note: expanded from macro 'NAN_DEPRECATED'
npm ERR! # define NAN_DEPRECATED __attribute__((deprecated))
npm ERR!                                        ^
npm ERR! 2 warnings and 1 error generated.
npm ERR! make: *** [Release/obj.target/usb_bindings/src/node_usb.o] Error 1

I am no expert in node/electron versions. It seems the GetContents was replaced by GetBackingStore that can be seen here: https://docs.google.com/document/d/1sTc_jRL87Fu175Holm5SV0kajkseGl2r8ifGY76G35k/edit

I guess an updated version of electron is required to move forward.

pandadefi commented 1 year ago

Nevermind I have pulled master instead of develop.