floating / frame

System-wide Web3 for macOS, Windows and Linux
https://frame.sh
GNU General Public License v3.0
1.07k stars 150 forks source link

Ledger connection is not working when connecting using the Ledger RSK app #789

Open john-light opened 2 years ago

john-light commented 2 years ago

I tested using Frame with the RSK app on a Ledger Nano X and it gives an error message Please reconnect this Ledger device.

I would like to have the ability to connect to Frame using the Ledger RSK app instead of the Ethereum app, since RSK is a different chain. I also think it will be less confusing to other users to use the RSK app to connect to the RSK chain, even though both Ethereum and RSK are EVM chains. (Maybe the Ledger Ethereum app should be renamed the EVM app if it is being used to connect to multiple different EVM chains, and not just to Ethereum -- but this is a discussion for Ledger, not Frame, so I digress.)

If support for the RSK app is implemented, it would be ideal if, per EIP-1191, the addresses generated used the RSK derivation paths:

RSK Mainnet: m/44'/137'/0'/0/N RSK Testnet: m/44'/37310'/0'/0/N

Test toolchain:

OS: Linux Mint 20.3 Frame version: 0.5-beta.21 Hardware wallet: Ledger Nano X Ledger app: RSK

sloppycoffee commented 2 years ago

Had the same issue. If you run frame from the command line you can see you don't have permission for that device. You need to add the udev rules.

https://github.com/LedgerHQ/udev-rules

john-light commented 2 years ago

@slayorktc the udev rules are installed. Hence my comment: "I do not have any problem connecting this Ledger to any other wallet apps."

mholtzman commented 2 years ago

are there any errors in the logs? does it immediately display this error or does it attempt to connect for a while first?

john-light commented 2 years ago

@mholtzman I think I figured out the issue. This message when I started Frame v0.5-beta.21 gave me a hint:

Screenshot 2022-07-15 142948

I was using the Ledger RSK app to connect, not the Ethereum app. I just tried using Frame v0.5-beta.21 with the Ethereum app and it worked as expected. But when I tried using the RSK app, I get the same error I originally reported above:

Screenshot 2022-07-15 142625

So I am going to edit my first post on this thread and update the title to reflect this finding.