search

floatlazer / semantic_slam

Real time semantic slam in ROS with a hand held RGB-D camera
GNU General Public License v3.0
612 stars 177 forks source link

Suggestion: remove hard inclusion of ORB-SLAM2 #24

Open kmfrick opened 4 years ago

kmfrick commented 4 years ago

Including the whole ORB-SLAM2 in the repository is unnecessary, as most users of this will already have their own version of ORB-SLAM2 installed. Moreover, in case updates are made to the original ORB-SLAM2 repo, the version included here will be outdated. I suggest you either include it as a submodule linked to the original repo, or remove it altogether and send users to the original repo in the README.

russelldj commented 2 years ago

I'd agree. I'm working on modularizing this work on my fork since in our case we rely on different SLAM and semantics methods than what is supported, but the overall concept is still very useful.