flobz / psa_car_controller

Control psa car with connected_car v4 API.
GNU General Public License v3.0
391 stars 199 forks source link

Feature request: ability to move config out of docker container or to point to outside #531

Closed RMHogervorst closed 1 year ago

RMHogervorst commented 1 year ago

The following issues all have to do with running psa_car_controller in a docker container (sometimes with home assistant)

It would be super useful if the config lived outside the container. or if we could map the config folder from the container to an outside folder under user control.

mdkeil commented 1 year ago

For docker you can make a bind to the internal /config folder to have full access to all of the important configuration-files.

codeclinic commented 1 year ago

For docker you can make a bind to the internal /config folder to have full access to all of the important configuration-files.

Interesting. But, that doesn't mean much to most users. Could you elaborate on what needs to be done?

mdkeil commented 1 year ago

Interesting. But, that doesn't mean much to most users. Could you elaborate on what needs to be done?

it depends on the docker-environment.. e.g. link1 link2

https://github.com/flobz/psa_car_controller/blob/master/docs/Docker.md

RMHogervorst commented 1 year ago

I mostly ask because I want to have the config outside the container for home assistant, but I don't know what is needed to make that happen. I made a start at this issue in the home assistant repository https://github.com/flobz/psacc-ha/issues/31 but I'm unsure of how to proceed to test this

RMHogervorst commented 1 year ago

also so I can add the co2 signal and other tokens to the docker config

codeclinic commented 1 year ago

Interesting. But, that doesn't mean much to most users. Could you elaborate on what needs to be done?

it depends on the docker-environment.. e.g. link1 link2

https://github.com/flobz/psa_car_controller/blob/master/docs/Docker.md

In most cases (as is mine) people are going to be using this as an addon via a HassOS rpi based system.

mdkeil commented 1 year ago

@RMHogervorst is on the right way.. I think @flobz has to config the /config via map at https://github.com/flobz/psacc-ha/blob/main/psacc-ha/config.json

flobz commented 1 year ago

Look at https://github.com/flobz/psacc-ha/tree/main/psacc-ha#modify-config-file Config is already map outside container.