flocascio / get-flash-videos

Automatically exported from code.google.com/p/get-flash-videos
0 stars 0 forks source link

Twitter meta headers break bbc, with older html::parser #567

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Install get_flash_videos from optware or debian squeeze
2. get_flash_videos http://www.bbc.co.uk/news/uk-politics-16509892

What version of the product are you using? On what operating system?
This is caused by an old HTML::Parser, which is present on optware and debian 
squeeze.

Please provide any additional information below.
get_flash_videos complains it can't find a video, failing to mention that the 
page content is truncated by a non-fatal yet fatal error.

https://github.com/monsieurvideo/get-flash-videos/pull/142 fixes the error 
reporting, allowing users to google "Illegal field name 'X-Meta-Twitter:card' 
at /usr/lib/perl5/HTML/HeadParser.pm line 207"

Alternatively, https://github.com/monsieurvideo/get-flash-videos/pull/143 
disables the broken functionality completely.

Original issue reported on code.google.com by atomicdryad on 21 May 2014 at 8:13