search

flocasts / flo-angular

A collection of Angular components for universal video playback. 📹
https://flosports-component-library.herokuapp.com
MIT License
10 stars 2 forks source link

Unable to go fullscreen on iPhoneX running on IOS13 #227

Closed joseph118 closed 4 years ago

joseph118 commented 4 years ago

Importing the FloFullscreenModule and trying to go fullscreen on IOS 13.1.3 doesn't seem to work

patrickmichalina commented 4 years ago

Confirming it happens on this demo page?

https://flosports-component-library.herokuapp.com/fullscreen

patrickmichalina commented 4 years ago

I tested in 13.3 and it works but don’t have a device with that exact version to test with

joseph118 commented 4 years ago

Testing on iPhone X running on iOS 13.3 IMG_20191213_160553

It seems that the fullscreen on the video player works (3rd fullscreen), but the buttons related with 1st and 2nd container doesn't. Infact, the buttons are not visible on the iPhone screen.

In my project, I'm currently using the provided service from FloFullscreenCommonModule - FloFullscreenService to go in and out of fullscreen however I cannot see any errors and nothing happens on this iPhone.

patrickmichalina commented 4 years ago

Those two buttons won’t show on iOS since it does not support the fullscreen API. the third button is special and shows because it’s attached to a video element which does have a fullscreen event it can fire.

patrickmichalina commented 4 years ago

I haven’t documented these subtleties so understandably confusing.

patrickmichalina commented 4 years ago

Oh I misread the original title of your issue!

I assumed you meant video elements weren’t working - which would have been a bug. Only video elements can go fullscreen in iOS Safari since the Fullscreen API is not supported in iPhone iOS. It IS supported in newer versions of iOS on iPad however.

This is why those fullscreen buttons do not show on iOS for iPhone since it is not supported.

joseph118 commented 4 years ago

Sorry for the lack of information from my end, I wasn't yet sure what the problem was considering it worked on all devices including iPad.

Thank you for pointing out the problem :)

patrickmichalina commented 4 years ago

I think another thing to consider is to DISABLE the buttons instead of removing them from the DOM like the current directives do. That’s a feature I’ve been thinking about lately.