search

floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.7k stars 240 forks source link

Failed to decrypt file when moved to another folder #1159

Open mneiger opened 2 years ago

mneiger commented 2 years ago

Which version of floccus are you using?

4.13.1

Sync method

{"label"=>"WebDAV"}

Which browser are you using? In case you are using the Android App, specify the Android version please.

Opera 86.0.4363.50 / FIrefox 100.0

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

v23.0.3

What kind of WebDAV server are you using? (if relevant)

Nextcloud v23.0.3

Describe the Bug

if I move the bookmark xbel file to another folder and adjust the floccus configuration accordingly, then it refuses to sync again and reports:

E030: Failed to decrypt bookmarks file. The passphrase may be wrong or the file may be corrupted

floccus-4.13.1-2022-05-11.log

resetting to old location works

Expected Behavior

it should accept to the new file location and continue syncing

To Reproduce

stop auto-sync connect to nextcloud (webdav) server move the xbel file to another location wait some time (just in case) edit floccus options and adjust "bookmarks file path" accordingly save the options ask floccus to "sync now"

Debug log provided

mneiger commented 2 years ago

Still in 4.14.0

mneiger commented 2 years ago

Still here in 4.15.0

mneiger commented 2 years ago

and still here in 4.16.0 :-(

mneiger commented 2 years ago

Still here in 4.17.0 and nextcloud 23.0.4

mneiger commented 2 years ago

And still here in 4.17.1 and nextcloud 24.0.4 :-(

marcelklehr commented 2 years ago

Hey @mneiger Thank you for reporting this. I can confirm this is an issue. It's currently by design, but I can understand that this is frustrating. That said, Google Drive is not a high priority for me atm, so it will take some time until I get to this.

mneiger commented 2 years ago

Hi @marcelklehr , thanks for the confirmation. I feared it was something like the path being embedded in the encrypting code. It really means I will have to handle my migration another way. However, I'm not using google drive but webdav on Nextcloud which is a more "native" platform to Floccus.

mneiger commented 2 years ago

Hi @marcelklehr , I finally migrated my bookmark data by recreating the xbel file. I'm still ready to help testing if there's ever a fix. However, if this is webdav specific, I wonder whether this is not in the end to be considered a duplicate of #1263 .

Thanks.

marcelklehr commented 3 months ago

I'm starting to migrate the encryption now to move away from using the path as a salt. Once this change has propagated to all clients, I can roll out the actual change, in about a month.