search

floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.88k stars 241 forks source link

Auto-sync toggle doesn't seem work on native/Android #1465

Closed kolinger closed 11 months ago

kolinger commented 11 months ago

Which version of floccus are you using?

develop

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

No response

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

New auto-sync enable toggle (in WebDAV profile OptionsWebdav.vue) doesn't seem to have effect. I can activate it (animation plays) it but it doesn't save, no console output is generated and I can see that my account is still enabled: false. If I Save and then go back to profile settings then auto-sync is disabled again.

My account is imported that's why it has enabled: false.

I tried to look how is enabled handled but I don't even understand how enabled could get into AccountStorage/Preferences let alone if something could be overriding enabled to false. This is very magic indeed.

Expected Behavior

Auto-sync enable should persist.

To Reproduce

Try to use auto-sync toggle on native/Android and see if it sticks.

Debug log provided

github-actions[bot] commented 11 months ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

marcelklehr commented 11 months ago

Thanks for filing the issue! :) I used the wrong event handler :D https://github.com/floccusaddon/floccus/commit/0aa47fed2e3210b848f571beb62e4ef78e7e206a

kolinger commented 11 months ago

Works but I see visual bug - Preferences/AccountStorage enabled gets true but if I return to profile settings then toggle shows off even if profile has enabled: true. If I toggle on then back off (to set false) then result is enabled: null. Something is off. Toggle sets value but doesn't read it back.

Do you see this visual bug as well?