floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.79k stars 241 forks source link

[Self-signed certificate; v5.x] E017: Network error #1560

Open swirlypillow opened 8 months ago

swirlypillow commented 8 months ago

Which version of floccus are you using?

5.0.10

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Brave

Version 1.63.169 Chromium: 122.0.6261.111

Which version of Nextcloud Bookmarks are you using? (if relevant)

13.1.3

Which version of Nextcloud? (if relevant)

28.0.3

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I get a "E017: Network error: Check your network connection and your account details" after upgrading to 5.0.10. I am using a Nextcloud instance hosted on my private network. The site is accessible over 443, and is using a self-signed certificate. The certificate is not expired, but the browser marks the site as not secure because it is self-signed. I'm not sure this is totally relevant, because with the last version of Floccus 4, this did not seem to matter. All I had to do was navigate to the Nextcloud site and accept the security warning, and everything worked fine. Now I get this error. I've tried deleting the profile and recreating it, which did not help.

Expected Behavior

I expected my bookmarks to continue to sync with Nextcloud Bookmarks as they have always done.

To Reproduce

Click the "sync now" button or click the "sync all profiles" button.

Debug log provided

I would but it generates a 0 byte file so there's nothing to attach.

github-actions[bot] commented 8 months ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

grg5811 commented 7 months ago

Good morning, same problem, with two machines, one with Debian 11 and the other with Debian 12. Brave browser. Synchronization no longer works, error E017, after updating to version 5.0.10.

grg5811 commented 7 months ago

Good morning, I don't know if it can help. I tried version 5.0.10, with Firefox version 123.0.1 always with nextcloud, and it works well here.

marcelklehr commented 7 months ago

Mh, I'm not sure what could have caused this, maybe manifest v3 is more strict when it comes to self-signed certs

grg5811 commented 7 months ago

Is there any solution or do you recommend reinstalling version 4....?

marcelklehr commented 7 months ago

I haven't had time to reproduce and investigate yet. Quick fix would certainly be to go back to v4.x but that will stop working some time in June/July when Google enforces manifest v3

Kyetech-IT-Manager commented 7 months ago

I'll add my 2 cents in

Had the same E017 issue with a TrueNAS Core TrueNAS-13.0-U4 WebDav share

The cert on the server is from our an internal CA and is a wildcard cert on the TrueNAS system Using Chrome to browse to the same URL 'https://kye-nas01:8081/Share01/' that the floccus profile uses, gave a certificate not valid message changing the URL in Chrome to 'https://kye-nas01.kyetech.local:8081/Share01/' - chrome now sees it as a valid cert

in the floccus profile the URL was https://kye-nas01:8081/Share01/

After changing the URL to https://kye-nas01.kyetech.local:8081/Share01/

I hope this helps with others

mvozzo commented 6 months ago

Is there any solution or do you recommend reinstalling version 4....?

Thanks @swirlypillow for posting this issue. I love Floccus but I too encountered the exact same issue and got very frustrated.

THE SOLUTION I downgraded to Floccus v4.19.1 by uninstalling the current version and manually install the old version. This works with my homelab installation of Nextcloud Self Signed Certificates on the latest versions of

Message to @marcelklehr May I suggest you run a poll to all your loyal Floccus users and gauge how many are using Self-signed vs purchased an SSL certificate?

I think you may be pleasantly surprised how many people are using "Self-signed" and will be impacted by Google's manifest 3 forced rollout come June/July as this will leave many stranded and frustrated with no work around.

However, if you were to come up with workaround with Nextcloud Bookmarks, that would be superb and would keep your loyal fans of Floccus happy. Just a thought.

marcelklehr commented 6 months ago

Thank you for weighing in @mvozzo! I understand that this is frustrating. Unfortunately, I have no way to influence Chromium's (and derivatives) SSL/TLS behavior. If you know other addons that have transitioned to manifest v3 already and are working with self-signed certificates, I could perhaps take a leaf out of their book, but so far I see no option to fix this. I'm sorry. :crying_cat_face:

Update: This is filed in chrome's bug tracker already, so here's hoping it will be fixed soon :)

mvozzo commented 6 months ago

If you know other addons that have transitioned to manifest v3 already and are working with self-signed certificates,

Thanks for the reply @marcelklehr I have a followup question... Out of curiosity (as I'm not a developer) does this mean those of us running homelab Nextcloud servers with Self-Signed Certificates are going to have issues (not just with Floccus) but with everything, once Google removes support for manifest v2?

marcelklehr commented 6 months ago

does this mean those of us running homelab Nextcloud servers with Self-Signed Certificates are going to have issues (not just with Floccus) but with everything, once Google removes support for manifest v2?

Likely yes

accforgithubtest commented 5 months ago

does this mean those of us running homelab Nextcloud servers with Self-Signed Certificates are going to have issues (not just with Floccus) but with everything, once Google removes support for manifest v2?

Likely yes

Is firefox likely to run into the same issue with self-signed certificates ?

marcelklehr commented 5 months ago

I don't know, I don't think so, for now.

nooneto1 commented 3 months ago

Recently realized this has affected me too: NC server v27 accessed via a 192.168 IP w/ bookmarks NC plugin v13.1.3, w/ browser plugin v5.2.5. However, I also run the "Passwords" NC plugin v2023.12.32 w/ Passwords browser plugin v2.6.0 and I am able to synchronize those still.

Perhaps the author of that plugin might be able to assist with the problem?

marcelklehr commented 3 months ago

Hi @nooneto1 Thank you for weighing in. It appears that they haven't upgraded to manifest v3 yet: https://github.com/marius-wieschollek/passwords-webextension/blob/master/src/platform/chrome/manifest.json#L2 This means until they do the extension will soon stop being supported on Chrome, as far as I know.