floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.83k stars 241 forks source link

floccus ignores browser-specific links #1618

Open V00id opened 6 months ago

V00id commented 6 months ago

Which version of floccus are you using?

5.1.0

How many bookmarks do you have, roughly?

250

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Google Drive

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Edge 124.0.2478.105

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Hello, floccus ignores local Links like "edge://downloads/all". I've uploaded all my bookmarks into the file on Google Drive and works fine with the exception, that all my "edge" BMs are vanished.

Thanks in advanced.

Regards, V00id

Expected Behavior

Local Edge BMs are saved as well.

To Reproduce

Just add a BM, for example "edge://downloads/all" and then upload to remote. Delete local BMs. Then download BMs from remote back to local. No "edge://" BM.

Debug log provided

github-actions[bot] commented 6 months ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

marcelklehr commented 6 months ago

This is somewhat by design as not all browsers support edge links.

V00id commented 6 months ago

This is somewhat by design as not all browsers support edge links.

Hello, thanks for your immediate answer.

What you are saying is, that not floccus is refusing to transmit the links into the "bookmarks.xbel" file. The firefox browser is filtering them out at import time?

marcelklehr commented 6 months ago

No, sorry, floccus is filtering them, because creating them on Firefox would cause an error. But I suppose, it would be possible to filter them on firefox instead and allow adding them to the xbel file...

V00id commented 6 months ago

No, sorry, floccus is filtering them, because creating them on Firefox would cause an error. But I suppose, it would be possible to filter them on firefox instead and allow adding them to the xbel file...

Hm, the reason why anyone is using a bookmark managing addon is to exchange ONE bookmark collection for multiple browsers. So nothing should be filtered out.

It is the problem of the user, if he don't get it, that he should not use those Edge-Link in Firefox.

PS: Don't get me wrong, I find your floccus addon very good, and plan to donate and use it. I just want to point out this issue here.