Error: Detected creation of folder loop

[InfamousUser]

Which version of floccus are you using?

5.2.4

How many bookmarks do you have, roughly?

5000

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 128.0, Chrome 125.0.6422.76

Which version of Nextcloud Bookmarks are you using? (if relevant)

14.2.2

Which version of Nextcloud? (if relevant)

29.0.4

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

024-07-20T22:23:00.680Z Executed 4092 actions from 47 actions 2024-07-20T22:23:00.681Z Executed 4093 actions from 47 actions 2024-07-20T22:23:00.684Z Syncing failed with Detected creation of folder loop. Moving 3567 into its descendant 3567

Detected creation of folder loop. Moving 3567 into its descendant 3567 Last synchronized: 6 hours ago

Expected Behavior

Proper sync

To Reproduce

1. Install Floccus
2. Sync my bookmarks from Chrome one way
3. Sync my bookmarks to Firefox one way
4. Enable two way sync on both browsers
5. Move folders around
6. Profit

Debug log provided

• [ ] I have provided a debug log file

[github-actions[bot]]

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

[InfamousUser]

Hmm I seem to have removed the issue by deleting a folder, but this caused other data to be deleted. There were two same named folders, one in the other, it wouldn't sync. On the second PC it tried to move both folders besides each other, it didn't like what it did, first folder remained empty. I have rename the nested folder on the first PC, however that caused both folders to get deleted from both devices, resulting in data loss.

[marcelklehr]

Can you give me step by step instructions how to reproduce? that would be awesome

[marcelklehr]

I have some backlog of dev work that will hopefully fix correctness issues like this, but that will have to wait until I have some days of focus time

[InfamousUser]

Can you give me step by step instructions how to reproduce? that would be awesome

Sorry, tackling a bunch of other things... I do not have much better instructions. In the browser bookmarks I had a folder named "Folder1", inside that folder is a folder named "Folder2", and inside of that is a folder named "Folder2". This deepest folder got moved into trash. I have tried reproducing it now on v5.2.5, however it does not seem to happen immediately, I guess there are some conditions unless it was fixed in 5.2.5.