search

floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.56k stars 235 forks source link

Cancel button doesn't work #1682

Closed InfamousUser closed 1 month ago

InfamousUser commented 1 month ago

Which version of floccus are you using?

5.2.4

How many bookmarks do you have, roughly?

5000

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 128.0, Chrome 125.0.6422.76

Which version of Nextcloud Bookmarks are you using? (if relevant)

14.2.2

Which version of Nextcloud? (if relevant)

29.0.4

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Pressing cancel button while syncing doesn't change syncing.

Expected Behavior

Pressing cancel button while syncing changes the syncing status.

To Reproduce

  1. Sync
  2. Don't sync

Debug log provided

github-actions[bot] commented 1 month ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

InfamousUser commented 1 month ago

I see it has cancelled now, while I was writing the bug report. I accidentally started a sync while backing up and restoring bookmarks so I tried to stop it but it took a good minute or two to stop syncing. This make the button useless, might as well wait for it to stop the sync...

marcelklehr commented 1 month ago

I see it has cancelled now, while I was writing the bug report.

Yes, the cancel button doesn't work as immediately as it should

marcelklehr commented 1 month ago

It's kind of hard to immediately stop a running code fragment. In the next release the cancel action will just reload the whole extension to make this more immediate.

InfamousUser commented 1 month ago

Aren't interrupts made to handle things like these? I don't know too much about programming though, so maybe I'm completely wrong...