floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.56k stars 235 forks source link

syncing browser tabs (read only, no upload) fails while same config works when changed to sync bookmarks #1685

Closed vacy closed 1 month ago

vacy commented 1 month ago

Which version of floccus are you using?

5.2.4

How many bookmarks do you have, roughly?

5

Are you using other means to sync bookmarks in parallel to floccus?

no

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Chrome Version 126.0.6478.183 (Offizieller Build) (64-Bit)

Which version of Nextcloud Bookmarks are you using? (if relevant)

14.2.2

Which version of Nextcloud? (if relevant)

28.0.8

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

i want to setup a folder in nextcloud that contains tabs to be opened on any browser startup. configure floccus to sync from nextcloud as browser tabs, not bookmarks. tried to configure nested and not nested profiles. also configured to only download, not upload tabs.

On all syncs i get that message in floccus "No tab with id: 1997147818." The ID does not change.

But if I do change the config from browser tabs to bookmarks sync, then it works fine while i dont change any other config.

Expected Behavior

just sync and open the bookmarks contained in the nextcloud folder as tabs

To Reproduce

relevant json config:

this does not work:

[ { "localRoot": "tabs", "strategy": "slave", "syncInterval": 15, "nestedSync": false, "failsafe": true, "allowNetwork": false, "errorCount": 30, "clickCountEnabled": false, "type": "nextcloud-bookmarks", "serverRoot": "/startup-bookmarks", "includeCredentials": false, "allowRedirects": false, "enabled": true, "syncing": 0.15, "scheduled": false, "error": null } ]

this works:

[ { "localRoot": "242", "strategy": "slave", "syncInterval": 15, "nestedSync": false, "failsafe": true, "allowNetwork": false, "errorCount": 0, "clickCountEnabled": false, "type": "nextcloud-bookmarks", "serverRoot": "/startup-bookmarks", "includeCredentials": false, "allowRedirects": false, "enabled": true, "syncing": false, "scheduled": false, "error": null, "lastSync": 1721812503341 } ]

Debug log provided

github-actions[bot] commented 1 month ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

marcelklehr commented 1 month ago

Hi @vacy

Floccus expects the bookmarks on the server to be in a sub folder for each browser window. So, for your use case, you will need to create a new subfolder under /startup-bookmarks and put the links to open as tabs in there.

vacy commented 1 month ago

@marcelklehr thanks for the quick reply :) it kinda works that way, the error stays though.

aaand it does not seem to be what i did expected. it does not open the tabs upon browser startup, does it? only on a sync?

marcelklehr commented 1 month ago

it does not open the tabs upon browser startup, does it? only on a sync?

It should sync a few seconds after browser startup, but only if the last sync is more then X minutes old (X being the interval you configured)

it kinda works that way, the error stays though.

Can you try clearing the cache in the profile settings?

vacy commented 1 month ago

sorry, i didnt check anymore before i deleted the profile. i just go with regular sync by floccus :)

but thanks for your help!