floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.58k stars 237 forks source link

[Android] re-directed to cloud rather than "Grant Access" screen after successful login #1700

Open sunjam opened 3 weeks ago

sunjam commented 3 weeks ago

Which version of floccus are you using?

5.2.5

How many bookmarks do you have, roughly?

3k

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 129.0.1

Which version of Nextcloud Bookmarks are you using? (if relevant)

unsure, cannot access host

Which version of Nextcloud? (if relevant)

v29

What kind of WebDAV server are you using? (if relevant)

Nextcloud

Describe the Bug

After logging into my Nextcloud account I am not shown the option to grant access, but instead re-directed into Nextcloud itself.

Expected Behavior

After successful login, Grant Access button step.

To Reproduce

Log into Nextcloud from Floccus: Username, Password, Two Factor. Re-directed to actual cloud default app (Files or Dashboard) Closing out of this (X) takes me to the "Abort" step in Floccus. Select Abort and then Login again. Grant Access screen appears.

Occurred while testing #1129 on a new Android device. An alternative method for authentication would be

Debug log provided

github-actions[bot] commented 3 weeks ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus and have been maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

marcelklehr commented 3 weeks ago

I think this is an upstream issue in Nextcloud that has to do with using Twofactor. It seems to work without twofactor for me.

sunjam commented 3 weeks ago

I would be curious what other applications are impacted and will look for an open server issue to link this to.

sunjam commented 2 weeks ago

I think this is an upstream issue in Nextcloud that has to do with using Twofactor. It seems to work without twofactor for me.

From mobile devs chat: This depends how the login mechanism is done. The app needs to send a specific header: https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html

marcelklehr commented 2 weeks ago

I'm using login flow v2, I'm not aware of any header that needs setting.

sunjam commented 2 weeks ago

https://cloud.nextcloud.com/index.php/call/ex4id6qh