floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.8k stars 241 forks source link

Syncing Problems when changing the titles of bookmarks in the browser (at least Firefox) #1720

Open elmanuke opened 1 month ago

elmanuke commented 1 month ago

Which version of floccus are you using?

v5.2.7

How many bookmarks do you have, roughly?

50

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 130.0 (64-Bit)

Which version of Nextcloud Bookmarks are you using? (if relevant)

v14.2.5

Which version of Nextcloud? (if relevant)

v29.0.5

What kind of WebDAV server are you using? (if relevant)

I do not use a WebDAV server for syncing

Describe the Bug

When I do changes to my bookmarks in the Firefox Browser, i.e. changing the title, I have problems uploading these changes to nextcloud. The floccus addon shows the error "E018: Couldn't authenticate with the server.", sometimes even several times: Bildschirmfoto 2024-09-15 um 17 16 34

When I download the bookmarks from the remote server, my local title changes are overwritten (just as expected). However, when adding or removing bookmarks locally within Firefox, the described syncing problem does not occur. It is just related to title changes of existing bookmarks.

Expected Behavior

I would expect the changes to be uploaded to the remote Nextcloud server

To Reproduce

  1. Create a profile and setup some bookmarks and sync them with Nextcloud bookmarks
  2. Change the title of a bookmark in Firefox
  3. Try to upload the change you made to Nextcloud
  4. Observe the error

Debug log provided

github-actions[bot] commented 1 month ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket, if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

marcelklehr commented 1 month ago

Hello @elmanuke This is a strange one. Can you check the nextcloud log for errors? Is it possible that these are bookmarks that you don't have write access in Nextcloud Bookmarks, because they were shared with you by someone else?

elmanuke commented 1 month ago

Hi @marcelklehr, thanks for answering so quickly! I use nextcloud with the hetzner storageshare and I haven't found out how to get the logs of the nextcloud instance.. Also the write access should not be a problem..

But I tried a bit around and found out, that for some reason it does only affect some of my bookmarks. And these are the bookmarks, that are marked as duplicates in the nextcloud bookmarks app. However, I do not know why these bookmarks are labled as duplicates. They are only in one folder and actually only exist once, just like all the other bookmarks.

grafik

Even exporting all bookmarks as an html file, deleting everything in nextcloud bookmarks and importing them again did not help. After uploading via a sync with floccus, I again was not able to change the title of these 38 bookmarks within firefox afterwards.

Do you have an idea what could be the reason for the wrong duplicates and why that creates the weird title change error described above?

marcelklehr commented 1 month ago

This may have to do with the new trash bin feature in Nextcloud Bookmarks, could you try clearing the trash bin in Nextcloud Bookmarks?

elmanuke commented 1 month ago

I tried it, but it did not help. The weird thing is that, even after deleting all bookmarks in Nextcloud and uploading them again, I still have exactly the same behaviour.

However, I found another way how to get rid of the wrong duplicates: I changed the titles of all wrong duplicates in Nextcloud, downloaded them via floccus, changed the titles back in Firefox and uploaded them again via floccus. Now I got rid of that strange behaviour, but it's a lot of manual and individual bookmark debugging..

marcelklehr commented 1 month ago

So, the steps to reproduce would be

  1. Create two bookmarks with the same url in two different folders
  2. Try to change the title of one of the two bookmarks
  3. boom

Would this be correct? I'm going to add a test case for this.

elmanuke commented 1 month ago

Ah not really, I did not have any duplicate bookmarks in two separate folders, Nextcloud bookmarks for some reason just thought, that there were duplicates. But I have no idea why the bookmarks were interpreted as duplicates.

marcelklehr commented 1 month ago

Mmmh, the only reason for duplicates being detected where there are none, to my knowledge, could be the trash bin :/ But you said you'd cleared that before trying again.

elmanuke commented 1 month ago

I imported the same bookmarks file (html export file from firefox) hat caused the problem, in another nextcloud profile. There I did not see the wrong duplicate issue. So it must have been some kind of bookmarks stored in the background. Maybe clearing the trashbin does not work properly?

marcelklehr commented 1 month ago

It's possible that your bookmarks installation has some corrupt bookmarks that cause trouble :/ Can you try updating to v14.2.6 of Nextcloud Bookmarks to see if that fixes things?