floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.86k stars 241 forks source link

Chrome/Edge Bookmarks Bar != Firefox Bookmarks Toolbar #1733

Open stutopp opened 1 month ago

stutopp commented 1 month ago

Which version of floccus are you using?

5.3.0

How many bookmarks do you have, roughly?

125

Are you using other means to sync bookmarks in parallel to floccus?

no

Sync method

Google Drive

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Chrome 129.0.6668.71, Edge 129.0.2792.65, Firefox 130.0.1

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

In Chrome/Edge, the bookmarks toolbar is called "Bookmarks bar". In Firefox, the toolbar is called "Bookmarks Toolbar". Therefore, only Chrome/Edge or Firefox can sync from the bookmarks root, and the other must be nested in a single folder on the toolbar or in other bookmarks.

Expected Behavior

I expect my bookmarks to sync from root to root on supported browsers, with bookmarks on the toolbar being placed on the toolbar and other bookmarks being placed in other bookmarks.

To Reproduce

  1. Create a floccus sync from root in Chrome/Edge or Firefox.
  2. Sync to other browser.
  3. Bookmarks will be placed in a floccus folder under other bookmarks.
  4. OR, you can set the sync location to root and return a failure.

Debug log provided

github-actions[bot] commented 1 month ago

Hello :wave:

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket, if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue Cheers :blue_heart:

marcelklehr commented 1 month ago

I cannot reproduce this. I am aware that Chrome/Edge Bookmarks Bar != Firefox Bookmarks Toolbar and have added a mapping in the code that should take care of this and does so in my tests. Perhaps you could post the error message here?

jaimehrubiks commented 1 week ago

I'm assuming we are doing something wrong, but definitely this happens to me as well. I'm new to floccus and just created a profile in chrome. Then, I have this same issue both with Firefox and Zen Browser:

image

My chrome bookmarks are under Bookmarks Menu/Floccus (profile name)/Bookmarks bar. Instead of under Bookmarks Toolbar.

Should I choose a different set of options when creating the profile? @marcelklehr

marcelklehr commented 1 week ago

Should I choose a different set of options when creating the profile?

What's your current Local folder option in the various browsers?

jaimehrubiks commented 1 week ago

Thanks for pointing in the right direction, I found the issue. I used the export/import to file function, and I thought that the same settings would be in the new browser, I didn't even get a prompt to change the settings, so I assumed so. I changed the new browsers to "/" (root) and it started working fine.

marcelklehr commented 1 week ago

image