search

floere / phony

E164 international phone number normalizing, splitting, formatting.
http://florianhanke.com/phony/
MIT License
1.01k stars 226 forks source link

Implement Phony.safe_format #336

Closed ream88 closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.01%) to 98.074% when pulling dac14b02925da5c34615e081669758c5720efc38 on YodelTalk:safe_format into c7a71244ea42c425cfa680ead3f0bc049a45406d on floere:master.

floere commented 8 years ago

@ream88 Hi Mario! Sorry for taking so long to answer 😓 Thanks for providing a nice documentation in addition to the code.

One note about the code: when rescuing all exceptions, you also rescue e.g. SignalException, which prevents you from using Ctrl-C, for example.

I am disinclined to merge this, for the reason that format expects a number that is in the E164 format, i.e. the minimal information that is necessary for a number to be formatted. If that fails, the user of the library should know about it since there is an issue with the passed number. If they know what they are doing, they should of course be able to implement this themselves. But feel free to provide this as a gem that depends on phony! 😊