663 Austrian mobile number can be more than 6 digits.

floere / phony

E164 international phone number normalizing, splitting, formatting.

http://florianhanke.com/phony/

MIT License

1.01k stars 226 forks source link

663 Austrian mobile number can be more than 6 digits. #351

Closed nashby closed 7 years ago

nashby commented 7 years ago

We have a customer who confirmed that number +43663060377xx is correct Austrian mobile number.

@floere do you remember anything about that 663 mobile numbers have 6 digits. rule? Couldn't find anything on the internet.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 98.129% when pulling 72498400ca0bd10c0f85209eb02b3fb4bcab6f47 on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 98.129% when pulling 72498400ca0bd10c0f85209eb02b3fb4bcab6f47 on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

coveralls commented 7 years ago

Coverage increased (+0.0008%) to 98.097% when pulling 72498400ca0bd10c0f85209eb02b3fb4bcab6f47 on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

floere commented 7 years ago

@nashby Thanks Vasiliy! Instead of removing it, could we just expand the range to include the number you found to be ok? So (6..8)?

nashby commented 7 years ago

@floere Hey! Hmm, (6..8)? I think it should be 6..10 in my case. And if I change it to 6..10 it'll be the same rule as above in the definition. Is it ok?

floere commented 7 years ago

@nashby It's the amount of digits after the NDC, so for your case 8. Or do I misunderstand you?

floere commented 7 years ago

(Sadly, I can't remember the origin of "663 mobile numbers have 6 digits". I must have assumed it to be correct when I added specs and wrote the text – changes are fine, in any case 😊)

nashby commented 7 years ago

@floere if I bring rule with (6..8) back this one fails Phony.assert.plausible?('+43 663 1234 567890')

nashby commented 7 years ago

Since amount of digits 10 after 663 code. Or am I wrong?

floere commented 7 years ago

Your initial example was 43 663 060377xx, with 8 digits after 663.

nashby commented 7 years ago

@floere right! Sorry, I used wrong number in specs. I updated PR!

coveralls commented 7 years ago

Coverage remained the same at 98.096% when pulling cd89ad38f24d47c18ec423e3532d0b8e0b34d265 on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 98.128% when pulling b6a27981aefca999be165e115c7c461333ace7fd on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 98.128% when pulling b6a27981aefca999be165e115c7c461333ace7fd on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 98.128% when pulling b6a27981aefca999be165e115c7c461333ace7fd on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

coveralls commented 7 years ago

Coverage remained the same at 98.096% when pulling b6a27981aefca999be165e115c7c461333ace7fd on nashby:fix/austria-663 into e0d7591396f82484e19dd1f4f096c968adf7d72d on floere:master.

floere commented 7 years ago

@nashby Thanks for the PR and your patience! 😊 Released in 2.15.37 🚀

nashby commented 7 years ago

@floere thanks for merging! And thanks for great gem! ❤️

floere commented 7 years ago

@nashby My pleasure! Also, it's mainly great due to the fantastic contributors! ❤️