floere / phony

E164 international phone number normalizing, splitting, formatting.
http://florianhanke.com/phony/
MIT License
1.01k stars 226 forks source link

Issue #17: enhance Bulgarian support #412

Closed davidkovsky closed 6 years ago

davidkovsky commented 6 years ago

I didn't exactly follow the format from the previous Bulgaria PR. I'm still trying to grok the DSL. I hope this looks good. As always, I'm open to feedback and ideas for improvement.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.005%) to 99.405% when pulling 237032a8e1708e1fb61e059ae6bf07fa20bd6eea on davidkovsky:bulgaria into 25a834854ec3238a49518f1cf006c9cdfa289c0c on floere:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.005%) to 99.405% when pulling 237032a8e1708e1fb61e059ae6bf07fa20bd6eea on davidkovsky:bulgaria into 25a834854ec3238a49518f1cf006c9cdfa289c0c on floere:master.

davidkovsky commented 6 years ago

@floere how does this look?

floere commented 6 years ago

@davidkovsky Excellent! 🏆 Thanks so much, and I am truly sorry for the wait 😓 Released in 2.16.6 🚀

davidkovsky commented 6 years ago

Thanks!

On Tue, Nov 13, 2018 at 4:18 AM Florian R. Hanke notifications@github.com wrote:

@davidkovsky https://github.com/davidkovsky Excellent! 🏆 Thanks so much, and I am truly sorry for the wait 😓 Released in 2.16.6 🚀

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/floere/phony/pull/412#issuecomment-438230376, or mute the thread https://github.com/notifications/unsubscribe-auth/AADsh0NrNKSu9OrjlqM9iGXOyWdWbDgLks5uuqqFgaJpZM4WUOA1 .